Debugging fixes #7038
Merged
Debugging fixes #7038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
Gradle
MartinBalin
approved these changes
Feb 7, 2024
neilcsmith-net
approved these changes
Feb 7, 2024
|
IMHO if it builds with local variables, it is easier to attach to the daemon without recompilation for inspection. Also note that the |
|
Sure, no problem with that - I was just comparing with the pre-Dec 2023 behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Late as always, but this time at least not affecting the IDE operation ....
During debugging of #7037, I've realized that
debugflag was dropped during December from gradle tooling classes injected into gradle daemon. Debug info is needed for debugging and is very useful in stacktraces of user reports; I believe this change should go to the NB21 to provide better diagnostics.The second fix is the name of the evn variable that NBLS launcher reads to inject extra options to the NBLS server. We used dotted name for historical reasons, but it seems it should be changed so that it is easier to set it up from the shell launcher. Dotted env var name requires use of
envto launch the process, which is not always possible, i.e. in vscode remote development scenario that does a ssh login.None of the changes affect normal IDE or NBLS operation. Please consider to include it into RC3, if not being already built.